Skip to content

deps: update libuv to 1.52.0#61829

Open
nodejs-github-bot wants to merge 1 commit intomainfrom
actions/tools-update-libuv
Open

deps: update libuv to 1.52.0#61829
nodejs-github-bot wants to merge 1 commit intomainfrom
actions/tools-update-libuv

Conversation

@nodejs-github-bot
Copy link
Collaborator

This is an automated update of libuv to 1.52.0.

@nodejs-github-bot nodejs-github-bot added the dependencies Pull requests that update a dependency file. label Feb 15, 2026
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run. labels Feb 15, 2026
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 15, 2026
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Feb 15, 2026
@github-actions
Copy link
Contributor

Failed to start CI
- Validating Jenkins credentials
✔  Jenkins credentials valid
- Starting PR CI job
✘  Failed to start PR CI: 404 Not Found
https://github.com/nodejs/node/actions/runs/22032932485

@lpinca lpinca added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. labels Feb 15, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 18, 2026
@nodejs-github-bot
Copy link
Collaborator Author

@aduh95
Copy link
Contributor

aduh95 commented Feb 18, 2026

There seems to be a related failure on Windows:

stack: |-
  node:internal/assert/utils:146
    throw error;
    ^

  AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:
  + actual - expected

  + 'write EPIPE'
  - 'write EBADF'
            ^

      at Socket.<anonymous> (C:\workspace\node-test-binary-windows-js-suites\node\test\parallel\test-net-socket-write-after-close.js:15:16)
      at Socket.<anonymous> (C:\workspace\node-test-binary-windows-js-suites\node\test\common\index.js:507:15)
      at Socket.emit (node:events:508:20)
      at emitErrorNT (node:internal/streams/destroy:170:8)
      at emitErrorCloseNT (node:internal/streams/destroy:129:3)
      at process.processTicksAndRejections (node:internal/process/task_queues:90:21) {
    generatedMessage: true,
    code: 'ERR_ASSERTION',
    actual: 'write EPIPE',
    expected: 'write EBADF',
    operator: 'strictEqual',
    diff: 'simple'
  }

  Node.js v26.0.0-pre

@StefanStojanovic
Copy link
Contributor

I've taken a look at this. First of all, both native and JS tests (some other than the one mentioned in a previous comment) failed, so I reran the 2 jobs (native, JS), and the only failure left is the one from parallel.test-net-socket-write-after-close.

The reason for the failure seems to be the change from this PR. I do not know how the others feel, but for me personally, changing the expected behavior to a new error doesn't seem like a big issue and I'd go with that approach. Of course, I leave the option that there is something that would not allow this that I'm not aware of, so if there is, please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. dependencies Pull requests that update a dependency file. libuv Issues and PRs related to the libuv dependency or the uv binding. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

Comments